1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
|
<?php
/**
* @group Database
* @group medium
*/
class MessageGroupStatesUpdaterJobTest extends MediaWikiIntegrationTestCase {
protected function setUp() : void {
parent::setUp();
$this->setMwGlobals( [
'wgTranslateTranslationServices' => [],
'wgTranslateMessageNamespaces' => [ NS_MEDIAWIKI ],
] );
$this->setTemporaryHook( 'TranslatePostInitGroups', [ $this, 'getTestGroups' ] );
$mg = MessageGroups::singleton();
$mg->setCache( new WANObjectCache( [ 'cache' => wfGetCache( 'hash' ) ] ) );
$mg->recache();
}
public function getTestGroups( &$list ) {
$messages = [ 'key1' => 'msg1', 'key2' => 'msg2' ];
$list['group-trans'] = new MessageGroupWithTransitions( 'group-trans', $messages );
$list['group-notrans'] = new MessageGroupWithoutTransitions( 'group-notrans', [] );
return false;
}
public function testGetGroupsWithTransitions() {
$handle = new MockMessageHandle();
$groups = MessageGroupStatesUpdaterJob::getGroupsWithTransitions( $handle );
foreach ( $groups as $id => $transitions ) {
$this->assertEquals( 'group-trans', $id );
}
}
/**
* @dataProvider provideStatValues
*/
public function testGetStatValue( $type, $expected ) {
$stats = [
MessageGroupStats::TOTAL => 666,
MessageGroupStats::FUZZY => 111,
MessageGroupStats::TRANSLATED => 222,
MessageGroupStats::PROOFREAD => 111,
];
$actual = MessageGroupStatesUpdaterJob::getStatValue( $stats, $type );
$this->assertEquals( $expected, $actual );
}
public static function provideStatValues() {
return [
[ 'UNTRANSLATED', 333 ],
[ 'OUTDATED', 111 ],
[ 'TRANSLATED', 222 ],
[ 'PROOFREAD', 111 ],
];
}
/**
* @dataProvider provideMatchCondition
*/
public function testMatchCondition( $expected, $value, $condition, $max ) {
$actual = MessageGroupStatesUpdaterJob::matchCondition( $value, $condition, $max );
$this->assertEquals( $expected, $actual );
}
public static function provideMatchCondition() {
return [
[ true, 0, 'ZERO', 666 ],
[ false, 1, 'ZERO', 666 ],
[ true, 1, 'NONZERO', 666 ],
[ false, 0, 'NONZERO', 666 ],
[ true, 666, 'MAX', 666 ],
[ false, 0, 'MAX', 666 ],
[ false, 12, 'MAX', 666 ],
];
}
public function testGetNewState() {
$group = MessageGroups::getGroup( 'group-trans' );
$transitions = $group->getMessageGroupStates()->getConditions();
$stats = [ 5, 0, 0, 0 ];
$newstate = MessageGroupStatesUpdaterJob::getNewState( $stats, $transitions );
$this->assertEquals( 'unset', $newstate, 'all zero, should be unset' );
$stats = [ 5, 1, 0, 0 ];
$newstate = MessageGroupStatesUpdaterJob::getNewState( $stats, $transitions );
$this->assertEquals( 'inprogress', $newstate, 'one translated message' );
$stats = [ 5, 0, 1, 0 ];
$newstate = MessageGroupStatesUpdaterJob::getNewState( $stats, $transitions );
$this->assertEquals( 'inprogress', $newstate, 'one outdated message' );
$stats = [ 5, 1, 1, 0 ];
$newstate = MessageGroupStatesUpdaterJob::getNewState( $stats, $transitions );
$this->assertEquals( 'inprogress', $newstate, 'one translated and one outdated message' );
$stats = [ 5, 5, 0, 0 ];
$newstate = MessageGroupStatesUpdaterJob::getNewState( $stats, $transitions );
$this->assertEquals( 'proofreading', $newstate, 'all translated' );
}
/**
* @group Broken
* This tests fails regularly on WMF CI but haven't been able to reproduce locally.
*/
public function testHooks() {
$user = $this->getTestSysop()->getUser();
$group = MessageGroups::getGroup( 'group-trans' );
// In the beginning...
$currentState = ApiGroupReview::getState( $group, 'fi' );
$this->assertFalse( $currentState, 'groups start from unset state' );
// First translation
$title = Title::newFromText( 'MediaWiki:key1/fi' );
$page = WikiPage::factory( $title );
$content = ContentHandler::makeContent( 'trans1', $title );
$status = $page->doEditContent( $content, __METHOD__, 0, false, $user );
self::runJobs();
$currentState = ApiGroupReview::getState( $group, 'fi' );
$this->assertEquals( 'inprogress', $currentState, 'in progress after first translation' );
// First review
ApiTranslationReview::doReview( $user, self::getRevisionRecord( $status ), __METHOD__ );
self::runJobs();
$currentState = ApiGroupReview::getState( $group, 'fi' );
$this->assertEquals( 'inprogress', $currentState, 'in progress while untranslated messages' );
// Second translation
$title = Title::newFromText( 'MediaWiki:key2/fi' );
$page = WikiPage::factory( $title );
$content = ContentHandler::makeContent( 'trans2', $title );
$status = $page->doEditContent( $content, __METHOD__, 0, false, $user );
self::runJobs();
$currentState = ApiGroupReview::getState( $group, 'fi' );
$this->assertEquals( 'proofreading', $currentState, 'proofreading after second translation' );
// Second review
ApiTranslationReview::doReview( $user, self::getRevisionRecord( $status ), __METHOD__ );
self::runJobs();
$currentState = ApiGroupReview::getState( $group, 'fi' );
$this->assertEquals( 'ready', $currentState, 'ready when all proofread' );
// Change to translation
$title = Title::newFromText( 'MediaWiki:key1/fi' );
$page = WikiPage::factory( $title );
$content = ContentHandler::makeContent( 'trans1 updated', $title );
$page->doEditContent( $content, __METHOD__, 0, false, $user );
self::runJobs();
$currentState = ApiGroupReview::getState( $group, 'fi' );
$this->assertEquals(
'proofreading',
$currentState,
'back to proofreading after translation changed'
);
}
protected static function getRevisionRecord( Status $s ) {
$value = $s->getValue();
return $value['revision-record'];
}
protected static function runJobs() {
do {
$job = JobQueueGroup::singleton()->pop();
if ( !$job ) {
break;
}
$job->run();
} while ( true );
}
}
class MockMessageHandle extends MessageHandle {
public function __construct() {
}
public function getGroupIds() {
return [ 'group-trans', 'group-notrans' ];
}
}
class MessageGroupWithoutTransitions extends MockWikiMessageGroup {
public function getMessageGroupStates() {
return new MessageGroupStates();
}
}
class MessageGroupWithTransitions extends MockWikiMessageGroup {
public function getMessageGroupStates() {
return new MessageGroupStates( [
'state conditions' => [
[ 'ready', [ 'PROOFREAD' => 'MAX' ] ],
[ 'proofreading', [ 'TRANSLATED' => 'MAX' ] ],
[
'unset',
[
'UNTRANSLATED' => 'MAX',
'OUTDATED' => 'ZERO',
'TRANSLATED' => 'ZERO'
]
],
[ 'inprogress', [ 'UNTRANSLATED' => 'NONZERO' ] ],
]
] );
}
}
|
GitWeb