Deal with new coreutils, the new cut insists you start from 1, not 0. Also, be a bit more intelligent about generating labels, do not prefix the backup label with o if the name is unique already. Quote a few variables too.

Package-Manager: portage-2.1.4

6 files changed, 250 insertions, 48 deletions

diff --git a/sys-boot/lilo/ChangeLog b/sys-boot/lilo/ChangeLog
index 2ca5869193fa..79c1d9d655d8 100644
--- a/sys-boot/lilo/ChangeLog
+++ b/sys-boot/lilo/ChangeLog
@@ -1,6 +1,14 @@
 # ChangeLog for sys-boot/lilo
-# Copyright 1999-2007 Gentoo Foundation; Distributed under the GPL v2
-# $Header: /var/cvsroot/gentoo-x86/sys-boot/lilo/ChangeLog,v 1.50 2007/04/28 22:03:26 ulm Exp $
+# Copyright 1999-2008 Gentoo Foundation; Distributed under the GPL v2
+# $Header: /var/cvsroot/gentoo-x86/sys-boot/lilo/ChangeLog,v 1.51 2008/01/31 13:26:02 chainsaw Exp $
+
+*lilo-22.8-r2 (31 Jan 2008)
+
+  31 Jan 2008; Tony Vroon <chainsaw@gentoo.org> lilo-22.7.3-r1.ebuild,
+  lilo-22.8.ebuild, lilo-22.8-r1.ebuild, +lilo-22.8-r2.ebuild:
+  Deal with new coreutils, the new cut insists you start from 1, not 0. Also,
+  be a bit more intelligent about generating labels, do not prefix the backup
+  label with o if the name is unique already. Quote a few variables too.
 
 *lilo-22.8-r1 (28 Apr 2007)
 
diff --git a/sys-boot/lilo/Manifest b/sys-boot/lilo/Manifest
index 533b1ce5935e..20869a25a316 100644
--- a/sys-boot/lilo/Manifest
+++ b/sys-boot/lilo/Manifest
@@ -1,3 +1,6 @@
+-----BEGIN PGP SIGNED MESSAGE-----
+Hash: SHA1
+
 AUX lilo-22.7.3-correct-usage-info.patch 557 RMD160 00947306d7b609ae0a0129e0a3f820a51a4d1f75 SHA1 572ae21eb4f65aed1410638fbd416eb4cee6d64c SHA256 dc32b41ef2024c7b38b3dde281ac1dae69f9353ce56adce79ca4030b13c65281
 AUX lilo-22.7.3-lvm2-not-partionable.patch 722 RMD160 72fda5286c36af505a1106aa4d8377907965b6f4 SHA1 e73465c9b8ef695dc5bcaf369098111f7d3563ed SHA256 ba33153df87056fa1d94194f51d7f2c57c46fc70d4463876b4bf7925b800a3a1
 AUX lilo-22.7.3-makefile-nodiags.patch 435 RMD160 8cf672abef1161ce10500f7dd78687aa076b0245 SHA1 e060cfaa1574bb40f31e50ba31e66882664c8b4f SHA256 568c6b04b8a203e3145358070e1c59b1df9f3ceea6719d855f54f1e0ed7a2b6d
@@ -9,10 +12,19 @@ AUX lilo-22.8-nodevmapper.patch 437 RMD160 1c70c8d9b107f0210cbc90e6c005d0a079de0
 AUX lilo-22.8-novga.patch 831 RMD160 b48d96a16e2be1e4c26372d27fd41a3830293947 SHA1 6b17310e2c71c605a7a2e816ac2a02b326ee6d28 SHA256 5ff92c00ce2624a070ebb616ab2efede5460cdd229d0e9bc97e4ddc65daa1e8a
 AUX lilo.conf 1722 RMD160 8f4c152ae448cd4ae46c379884a2fe4adbf64d4b SHA1 75c7374359acb94955026a1f626c5355d70829cd SHA256 1cc9e4828e7b61f7c0ebf6655d7d6be3b584461308b568267f3c1bb7fb8371d0
 DIST dolilo-0.4.tar.bz2 3753 RMD160 e63d7d258461346620d012d8e89b22b3f969b089 SHA1 887c778c2cc603d24995a5ab58c6cdce974bd88a SHA256 812f7cb7a9c93eade7afaa8f12955723c4bdaede1c61f90162390dedfc37bd2e
+DIST dolilo-0.5.tar.bz2 3777 RMD160 10a060878ee3fc50ba109c8d2decdd6b409bed2e SHA1 9617479e3736c24d3c06628c540a5eaeb184d849 SHA256 9b6994ec6416cdfb0205665a58dc2e6a1d6e36272a3cab94315daea1c55605f1
 DIST lilo-22.7.3.src.tar.gz 436177 RMD160 265e5934183ed01ae74641161ac5eec28716f944 SHA1 d6de449607dfca518ca4e0d5d3be5d7d98eab0e5 SHA256 606aa55b66b6dd8baab0465b7c23aa84a48e594a13b41eb995178a1ca2651fc5
 DIST lilo-22.8.src.tar.gz 437555 RMD160 b452f4821cbc917b29cf168587652a6f1efd33e1 SHA1 59852eab59b93dcea63b39eef1db7963b7268b0d SHA256 bad5907c212c0b2b15de5e852787a1ad2129a702f113b26345eec1c917c4edcb
-EBUILD lilo-22.7.3-r1.ebuild 4646 RMD160 57590654b4d5a6a04efc9846a028b0ef0259afa5 SHA1 440e5b1115e6087ed6ad2f3f903dd69927e1a422 SHA256 462180b8f6460942568e4cc47ffe32c0f649556446a2a76b57432882d4b12d96
-EBUILD lilo-22.8-r1.ebuild 4625 RMD160 2a2668d439258c8aebb4130da2613d4544f71364 SHA1 0cb213a2bda6ceab9445597c1a0b31cf37f4941b SHA256 3ba29b0aa790c3f3464e5e0c0a589593504cf0229d651537a21b074843a923e0
-EBUILD lilo-22.8.ebuild 4493 RMD160 89542661c6f09e7e5f8fb86f5e8c209c17ba8d91 SHA1 64fbd5d14890af41bc21b6983a2b965caf7cad7c SHA256 e99acbb2ab232e13cf67cbe4a05547688406041171fdbb878c246c5c64cc8a65
-MISC ChangeLog 9232 RMD160 a2ceb82daebc89cd301c9e2c7200e6682601183a SHA1 49c56d014f5d0cd5a817a683bc5c5f68b900b588 SHA256 0fc45d355a4ce3d6842c0ba45211c71c713981c2023407d357d850b453c9dc8a
+EBUILD lilo-22.7.3-r1.ebuild 4663 RMD160 aa3a460d118b1ac456ccb4e8e2c663f48864f82f SHA1 94a8bcb4b88ac406cc3f2f4e605b7831c6e045d2 SHA256 cd2eb0e4a8401bde703a85270971524de85174e57183b98cbdb1a987a76613d8
+EBUILD lilo-22.8-r1.ebuild 4640 RMD160 6b0c731a89fbdb9bd71d170f3c27bf22e5c86af6 SHA1 d3beebbe052fdc1ed7be00a327aee89d34978c92 SHA256 8be98f19d2b745853c234605cce6bc1f1f2dce8752cc89ec07e177b22b51c73c
+EBUILD lilo-22.8-r2.ebuild 4640 RMD160 404211da6c2838753d3fefe44db293b583a60507 SHA1 01903a17ad1e1c9bc06779a379fdb4004b13e608 SHA256 1606ef61ee5e46144155296c308fbdb2974f5e7a9c7e4a7cec07f5b6cc810f44
+EBUILD lilo-22.8.ebuild 4506 RMD160 f6787a266c7d92f63b8df3927fc9abf27efa22ce SHA1 3b6fb27a12a992f839ddab8c6ed3874a20dcf128 SHA256 e57b4e6e1806b56f4baaf5051c0995098ff98016c49cdf36dd3c2db668d06762
+MISC ChangeLog 9630 RMD160 136f7545e872d74ca70b45c7b6d7818618c08297 SHA1 85c1c74d9c7a2baffbf5c0ca1cb6ee392bcb6080 SHA256 dbd42069419a127524c41897f67ce43a77973720cd48a474f4046b6ca9fe6407
 MISC metadata.xml 254 RMD160 823c99a514af57fe285c45f08538b7cc18e6342a SHA1 de5f6d0faac7d5f11daa399f9e875c30cac2ce64 SHA256 2817a53a07dd68fef8ec5467cb1a8441e87d77bd7eaf8ce9971de1adfbab7bdc
+-----BEGIN PGP SIGNATURE-----
+Version: GnuPG v2.0.7 (GNU/Linux)
+
+iD8DBQFHoc2Cp5vW4rUFj5oRAkCxAJ4pMIxsaSnhsQ60WG1OisLCN9A8PACgka7h
+ZxKG3r8Ahfaevi2fFmYdlKI=
+=sASZ
+-----END PGP SIGNATURE-----
diff --git a/sys-boot/lilo/lilo-22.7.3-r1.ebuild b/sys-boot/lilo/lilo-22.7.3-r1.ebuild
index 1032400e9c01..3bc122dfeb5c 100644
--- a/sys-boot/lilo/lilo-22.7.3-r1.ebuild
+++ b/sys-boot/lilo/lilo-22.7.3-r1.ebuild
@@ -1,6 +1,6 @@
-# Copyright 1999-2007 Gentoo Foundation
+# Copyright 1999-2008 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/sys-boot/lilo/lilo-22.7.3-r1.ebuild,v 1.6 2007/07/15 02:25:03 mr_bones_ Exp $
+# $Header: /var/cvsroot/gentoo-x86/sys-boot/lilo/lilo-22.7.3-r1.ebuild,v 1.7 2008/01/31 13:26:02 chainsaw Exp $
 
 inherit eutils flag-o-matic toolchain-funcs
 
@@ -28,22 +28,22 @@ PROVIDE="virtual/bootloader"
 src_unpack() {
 	unpack ${MY_P}.tar.gz
 
-	cd ${S}
+	cd "${S}"
 
 	# Correctly document commandline options -v and -V, bug #43554
-	epatch ${FILESDIR}/${P}-correct-usage-info.patch
+	epatch "${FILESDIR}/${P}-correct-usage-info.patch"
 	# Install manpages to correct location, do not rely on incorrect manpath output, bug #117135
 	# Do not strip the main binary, it upsets portage, bug #140210
-	epatch ${FILESDIR}/${P}-makefile.patch
+	epatch "${FILESDIR}/${P}-makefile.patch"
 	# Do not install diag1.img, bug #149887
-	epatch ${FILESDIR}/${P}-makefile-nodiags.patch
+	epatch "${FILESDIR}/${P}-makefile-nodiags.patch"
 	# Do not try to read the partition table on LVM2
-	epatch ${FILESDIR}/${P}-lvm2-not-partionable.patch
+	epatch "${FILESDIR}/${P}-lvm2-not-partionable.patch"
 
 	# this patch is needed when booting PXE and the device you're using
 	# emulates vga console via serial console.
 	# IE..  B.B.o.o.o.o.t.t.i.i.n.n.g.g....l.l.i.i.n.n.u.u.x.x and stair stepping.
-	use pxeserial && epatch ${FILESDIR}/${P}-novga.patch
+	use pxeserial && epatch "${FILESDIR}/${P}-novga.patch"
 
 	unpack ${DOLILO_TAR}
 }
@@ -67,22 +67,22 @@ src_compile() {
 
 src_install() {
 	keepdir /boot
-	make ROOT=${D} install || die
+	make ROOT="${D}" install || die
 
 	if use !minimal; then
 		into /
-		dosbin ${S}/dolilo/dolilo
+		dosbin "${S}"/dolilo/dolilo
 
 		into /usr
 		dosbin keytab-lilo.pl
 
 		insinto /etc
-		newins ${FILESDIR}/lilo.conf lilo.conf.example
+		newins "${FILESDIR}"/lilo.conf lilo.conf.example
 
-		newconfd ${S}/dolilo/dolilo.conf.d dolilo.example
+		newconfd "${S}"/dolilo/dolilo.conf.d dolilo.example
 
 		doman manPages/*.[5-8]
-		dodoc CHANGES COPYING INCOMPAT README*
+		dodoc CHANGES INCOMPAT README*
 		docinto samples ; dodoc sample/*
 	fi
 }
@@ -145,10 +145,10 @@ lilocheck () {
 }
 
 pkg_postinst() {
-	if [ ! -e ${ROOT}/boot/boot.b -a ! -L ${ROOT}/boot/boot.b ]
+	if [ ! -e "${ROOT}"/boot/boot.b -a ! -L "${ROOT}"/boot/boot.b ]
 	then
 		[ -f "${ROOT}/boot/boot-menu.b" ] && \
-			ln -snf boot-menu.b ${ROOT}/boot/boot.b
+			ln -snf boot-menu.b "${ROOT}"/boot/boot.b
 	fi
 
 	if [ "${ROOT}" = "/" ] && use !minimal;
diff --git a/sys-boot/lilo/lilo-22.8-r1.ebuild b/sys-boot/lilo/lilo-22.8-r1.ebuild
index 10e509b468c2..1c968e89b239 100644
--- a/sys-boot/lilo/lilo-22.8-r1.ebuild
+++ b/sys-boot/lilo/lilo-22.8-r1.ebuild
@@ -1,6 +1,6 @@
-# Copyright 1999-2007 Gentoo Foundation
+# Copyright 1999-2008 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/sys-boot/lilo/lilo-22.8-r1.ebuild,v 1.3 2007/07/15 02:25:03 mr_bones_ Exp $
+# $Header: /var/cvsroot/gentoo-x86/sys-boot/lilo/lilo-22.8-r1.ebuild,v 1.4 2008/01/31 13:26:02 chainsaw Exp $
 
 inherit eutils flag-o-matic toolchain-funcs
 
@@ -29,20 +29,20 @@ PROVIDE="virtual/bootloader"
 src_unpack() {
 	unpack ${MY_P}.tar.gz
 
-	cd ${S}
+	cd "${S}"
 
 	# Correctly document commandline options -v and -V, bug #43554
-	epatch ${FILESDIR}/${P}-correct-usage-info.patch
+	epatch "${FILESDIR}/${P}-correct-usage-info.patch"
 	# Install manpages to correct location, do not rely on incorrect manpath output, bug #117135
 	# Do not strip the main binary, it upsets portage, bug #140210
 	# Do not install diag1.img, bug #149887
-	epatch ${FILESDIR}/${P}-makefile.patch
+	epatch "${FILESDIR}/${P}-makefile.patch"
 
 	# this patch is needed when booting PXE and the device you're using
 	# emulates vga console via serial console.
 	# IE..  B.B.o.o.o.o.t.t.i.i.n.n.g.g....l.l.i.i.n.n.u.u.x.x and stair stepping.
-	use pxeserial && epatch ${FILESDIR}/${P}-novga.patch
-	use device-mapper || epatch ${FILESDIR}/${P}-nodevmapper.patch
+	use pxeserial && epatch "${FILESDIR}/${P}-novga.patch"
+	use device-mapper || epatch "${FILESDIR}/${P}-nodevmapper.patch"
 
 	unpack ${DOLILO_TAR}
 }
@@ -66,22 +66,22 @@ src_compile() {
 
 src_install() {
 	keepdir /boot
-	make ROOT=${D} install || die
+	make ROOT="${D}" install || die
 
 	if use !minimal; then
 		into /
-		dosbin ${S}/dolilo/dolilo
+		dosbin "${S}"/dolilo/dolilo
 
 		into /usr
 		dosbin keytab-lilo.pl
 
 		insinto /etc
-		newins ${FILESDIR}/lilo.conf lilo.conf.example
+		newins "${FILESDIR}"/lilo.conf lilo.conf.example
 
-		newconfd ${S}/dolilo/dolilo.conf.d dolilo.example
+		newconfd "${S}"/dolilo/dolilo.conf.d dolilo.example
 
 		doman manPages/*.[5-8]
-		dodoc CHANGES COPYING INCOMPAT README*
+		dodoc CHANGES INCOMPAT README*
 		docinto samples ; dodoc sample/*
 	fi
 }
@@ -144,10 +144,10 @@ lilocheck () {
 }
 
 pkg_postinst() {
-	if [ ! -e ${ROOT}/boot/boot.b -a ! -L ${ROOT}/boot/boot.b ]
+	if [ ! -e "${ROOT}/boot/boot.b" -a ! -L "${ROOT}/boot/boot.b" ]
 	then
 		[ -f "${ROOT}/boot/boot-menu.b" ] && \
-			ln -snf boot-menu.b ${ROOT}/boot/boot.b
+			ln -snf boot-menu.b "${ROOT}/boot/boot.b"
 	fi
 
 	if [ "${ROOT}" = "/" ] && use !minimal;
diff --git a/sys-boot/lilo/lilo-22.8-r2.ebuild b/sys-boot/lilo/lilo-22.8-r2.ebuild
new file mode 100644
index 000000000000..874b4a2f214b
--- /dev/null
+++ b/sys-boot/lilo/lilo-22.8-r2.ebuild
@@ -0,0 +1,182 @@
+# Copyright 1999-2008 Gentoo Foundation
+# Distributed under the terms of the GNU General Public License v2
+# $Header: /var/cvsroot/gentoo-x86/sys-boot/lilo/lilo-22.8-r2.ebuild,v 1.1 2008/01/31 13:26:02 chainsaw Exp $
+
+inherit eutils flag-o-matic toolchain-funcs
+
+DOLILO_V="0.5"
+IUSE="static minimal pxeserial device-mapper"
+
+DESCRIPTION="Standard Linux boot loader"
+HOMEPAGE="http://lilo.go.dyndns.org/pub/linux/lilo/"
+DOLILO_TAR="dolilo-${DOLILO_V}.tar.bz2"
+MY_P=${P}.src
+
+SRC_URI="http://home.san.rr.com/johninsd/pub/linux/lilo/${MY_P}.tar.gz
+	ftp://metalab.unc.edu/pub/Linux/system/boot/lilo/${MY_P}.tar.gz
+	ftp://metalab.unc.edu/pub/Linux/system/boot/lilo/obsolete/${MY_P}.tar.gz
+	mirror://gentoo/${DOLILO_TAR}"
+
+SLOT="0"
+LICENSE="BSD GPL-2"
+KEYWORDS="-* ~x86 ~amd64"
+
+DEPEND=">=sys-devel/bin86-0.15.5
+	device-mapper? ( >=sys-fs/device-mapper-1.02.12 )"
+
+PROVIDE="virtual/bootloader"
+
+src_unpack() {
+	unpack ${MY_P}.tar.gz
+
+	cd "${S}"
+
+	# Correctly document commandline options -v and -V, bug #43554
+	epatch "${FILESDIR}/${P}-correct-usage-info.patch"
+	# Install manpages to correct location, do not rely on incorrect manpath output, bug #117135
+	# Do not strip the main binary, it upsets portage, bug #140210
+	# Do not install diag1.img, bug #149887
+	epatch "${FILESDIR}/${P}-makefile.patch"
+
+	# this patch is needed when booting PXE and the device you're using
+	# emulates vga console via serial console.
+	# IE..  B.B.o.o.o.o.t.t.i.i.n.n.g.g....l.l.i.i.n.n.u.u.x.x and stair stepping.
+	use pxeserial && epatch "${FILESDIR}/${P}-novga.patch"
+	use device-mapper || epatch "${FILESDIR}/${P}-nodevmapper.patch"
+
+	unpack ${DOLILO_TAR}
+}
+
+src_compile() {
+	# lilo needs this. bug 140209
+	export LC_ALL=C
+
+	# hardened automatic PIC plus PIE building should be suppressed
+	# because of assembler instructions that cannot be compiled PIC
+	HARDENED_CFLAGS="`test-flags-CC -fno-pic -nopie`"
+
+	# we explicitly prevent the custom CFLAGS for stability reasons
+	if use static; then
+		emake CC="$(tc-getCC) ${HARDENED_CFLAGS}" lilo.static || die
+		mv lilo.static lilo || die
+	else
+		emake CC="$(tc-getCC) ${HARDENED_CFLAGS}" lilo || die
+	fi
+}
+
+src_install() {
+	keepdir /boot
+	make ROOT="${D}" install || die
+
+	if use !minimal; then
+		into /
+		dosbin "${S}"/dolilo/dolilo
+
+		into /usr
+		dosbin keytab-lilo.pl
+
+		insinto /etc
+		newins "${FILESDIR}"/lilo.conf lilo.conf.example
+
+		newconfd "${S}"/dolilo/dolilo.conf.d dolilo.example
+
+		doman manPages/*.[5-8]
+		dodoc CHANGES INCOMPAT README*
+		docinto samples ; dodoc sample/*
+	fi
+}
+
+# Check whether LILO is installed
+# This function is from /usr/sbin/mkboot from debianutils, with copyright:
+#
+#   Debian GNU/Linux
+#   Copyright 1996-1997 Guy Maor <maor@debian.org>
+#
+# Modified for Gentoo for use with the lilo ebuild by:
+#   Martin Schlemmer <azarah@gentoo.org> (16 Mar 2003)
+#
+lilocheck () {
+	local bootpart=
+	local rootpart="$(mount | grep -v "tmpfs" | grep -v "rootfs" | grep "on / " | cut -f1 -d " ")"
+
+	echo
+	einfon "Checking for LILO ..."
+
+	if [ "$(whoami)" != "root" ]
+	then
+		echo; echo
+		eerror "Only root can check for LILO!"
+		return 1
+	fi
+
+	if [ -z "${rootpart}" ]
+	then
+		echo; echo
+		eerror "Could not determine root partition!"
+		return 1
+	fi
+
+	if [ ! -f /etc/lilo.conf -o ! -x /sbin/lilo ]
+	then
+		echo " No"
+		return 1
+	fi
+
+	bootpart="$(sed -n "s:^boot[ ]*=[ ]*\(.*\)[ ]*:\1:p" /etc/lilo.conf)"
+
+	if [ -z "${bootpart}" ]
+	then
+		# lilo defaults to current root when 'boot=' is not present
+		bootpart="${rootpart}"
+	fi
+
+	if ! dd if=${bootpart} ibs=16 count=1 2>&- | grep -q 'LILO'
+	then
+		echo; echo
+		ewarn "Yes, but I couldn't find a LILO signature on ${bootpart}"
+		ewarn "Check your /etc/lilo.conf, or run /sbin/lilo by hand."
+		return 1
+	fi
+
+	echo " Yes, on ${bootpart}"
+
+	return 0
+}
+
+pkg_postinst() {
+	if [ ! -e "${ROOT}/boot/boot.b" -a ! -L "${ROOT}/boot/boot.b" ]
+	then
+		[ -f "${ROOT}/boot/boot-menu.b" ] && \
+			ln -snf boot-menu.b "${ROOT}/boot/boot.b"
+	fi
+
+	if [ "${ROOT}" = "/" ] && use !minimal;
+	then
+		if lilocheck
+		then
+			einfo "Running DOLILO to complete the install ..."
+			# do not redirect to /dev/null because it may display some input
+			# prompt
+			/sbin/dolilo
+			if [ "$?" -ne 0 ]
+			then
+				echo
+				ewarn "Running /sbin/dolilo failed!  Please check what the problem is"
+				ewarn "before your next reboot."
+
+				ebeep 5
+				epause 5
+			fi
+		fi
+		echo
+	fi
+	if use !minimal; then
+		echo
+		einfo "Issue 'dolilo' instead of 'lilo' to have a friendly wrapper that"
+		einfo "handles mounting and unmounting /boot for you. It can do more then"
+		einfo "that when asked, edit /etc/conf.d/dolilo to harness it's full potential."
+		ebeep 5
+		epause 3
+		echo
+	fi
+}
diff --git a/sys-boot/lilo/lilo-22.8.ebuild b/sys-boot/lilo/lilo-22.8.ebuild
index 0347d9763669..8ca82185b5ef 100644
--- a/sys-boot/lilo/lilo-22.8.ebuild
+++ b/sys-boot/lilo/lilo-22.8.ebuild
@@ -1,6 +1,6 @@
-# Copyright 1999-2007 Gentoo Foundation
+# Copyright 1999-2008 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/sys-boot/lilo/lilo-22.8.ebuild,v 1.4 2007/07/15 02:25:03 mr_bones_ Exp $
+# $Header: /var/cvsroot/gentoo-x86/sys-boot/lilo/lilo-22.8.ebuild,v 1.5 2008/01/31 13:26:02 chainsaw Exp $
 
 inherit eutils flag-o-matic toolchain-funcs
 
@@ -28,19 +28,19 @@ PROVIDE="virtual/bootloader"
 src_unpack() {
 	unpack ${MY_P}.tar.gz
 
-	cd ${S}
+	cd "${S}"
 
 	# Correctly document commandline options -v and -V, bug #43554
-	epatch ${FILESDIR}/${P}-correct-usage-info.patch
+	epatch "${FILESDIR}/${P}-correct-usage-info.patch"
 	# Install manpages to correct location, do not rely on incorrect manpath output, bug #117135
 	# Do not strip the main binary, it upsets portage, bug #140210
 	# Do not install diag1.img, bug #149887
-	epatch ${FILESDIR}/${P}-makefile.patch
+	epatch "${FILESDIR}/${P}-makefile.patch"
 
 	# this patch is needed when booting PXE and the device you're using
 	# emulates vga console via serial console.
 	# IE..  B.B.o.o.o.o.t.t.i.i.n.n.g.g....l.l.i.i.n.n.u.u.x.x and stair stepping.
-	use pxeserial && epatch ${FILESDIR}/${P}-novga.patch
+	use pxeserial && epatch "${FILESDIR}/${P}-novga.patch"
 
 	unpack ${DOLILO_TAR}
 }
@@ -64,22 +64,22 @@ src_compile() {
 
 src_install() {
 	keepdir /boot
-	make ROOT=${D} install || die
+	make ROOT="${D}" install || die
 
 	if use !minimal; then
 		into /
-		dosbin ${S}/dolilo/dolilo
+		dosbin "${S}"/dolilo/dolilo
 
 		into /usr
 		dosbin keytab-lilo.pl
 
 		insinto /etc
-		newins ${FILESDIR}/lilo.conf lilo.conf.example
+		newins "${FILESDIR}"/lilo.conf lilo.conf.example
 
-		newconfd ${S}/dolilo/dolilo.conf.d dolilo.example
+		newconfd "${S}"/dolilo/dolilo.conf.d dolilo.example
 
 		doman manPages/*.[5-8]
-		dodoc CHANGES COPYING INCOMPAT README*
+		dodoc CHANGES INCOMPAT README*
 		docinto samples ; dodoc sample/*
 	fi
 }
@@ -142,10 +142,10 @@ lilocheck () {
 }
 
 pkg_postinst() {
-	if [ ! -e ${ROOT}/boot/boot.b -a ! -L ${ROOT}/boot/boot.b ]
+	if [ ! -e "${ROOT}"/boot/boot.b -a ! -L "${ROOT}"/boot/boot.b ]
 	then
 		[ -f "${ROOT}/boot/boot-menu.b" ] && \
-			ln -snf boot-menu.b ${ROOT}/boot/boot.b
+			ln -snf boot-menu.b "${ROOT}"/boot/boot.b
 	fi
 
 	if [ "${ROOT}" = "/" ] && use !minimal;