diff options
Diffstat (limited to '9999/0010-dirent-Deprecate-getdirentries.patch')
| -rw-r--r-- | 9999/0010-dirent-Deprecate-getdirentries.patch | 100 |
1 files changed, 0 insertions, 100 deletions
diff --git a/9999/0010-dirent-Deprecate-getdirentries.patch b/9999/0010-dirent-Deprecate-getdirentries.patch deleted file mode 100644 index 28f744a..0000000 --- a/9999/0010-dirent-Deprecate-getdirentries.patch +++ /dev/null @@ -1,100 +0,0 @@ -From 2f0668caf22acf6493dce8dcfd670e4b35fb6892 Mon Sep 17 00:00:00 2001 -From: Adhemerval Zanella <adhemerval.zanella@linaro.org> -Date: Fri, 17 Apr 2020 09:59:51 -0300 -Subject: [PATCH 10/10] dirent: Deprecate getdirentries - -The interface has some issues: - - 1. It is build on top getdents on Linux and requires handling - non-LFS call using LFS getdents. - - 2. It is not wildly used and the non-LFS support is as problematic - as non-LFS readdir. glibc only exports the LFS getdents. - - 3. It is not a direct replacement over BSD since on some plataform - its signature has changed (FreeBSD 11, for instance, used to - set the offset as a 'long' and changed to 'off_t' on version 12). - -The idea is to eventually move the symbols to compat ones. ---- - NEWS | 3 +++ - dirent/dirent.h | 14 ++++++++++---- - sysdeps/unix/sysv/linux/Makefile | 4 ++++ - 3 files changed, 17 insertions(+), 4 deletions(-) - -diff --git a/NEWS b/NEWS -index a10bb08fb0..2b4ed6bbc1 100644 ---- a/NEWS -+++ b/NEWS -@@ -21,6 +21,9 @@ Deprecated and removed features, and other changes affecting compatibility: - corresponds to the AT_PLATFORM system name, or employs the legacy AT_HWCAP - search mechanism, which was deprecated in version 2.33. - -+* The function getdirentries is now deprecated, applications should use -+ either getdents64, readdir64 or readdir. -+ - Changes to build and runtime requirements: - - [Add changes to build and runtime requirements here] -diff --git a/dirent/dirent.h b/dirent/dirent.h -index c47d3273b2..1c299e5be8 100644 ---- a/dirent/dirent.h -+++ b/dirent/dirent.h -@@ -350,29 +350,35 @@ extern int alphasort64 (const struct dirent64 **__e1, - /* Read directory entries from FD into BUF, reading at most NBYTES. - Reading starts at offset *BASEP, and *BASEP is updated with the new - position after reading. Returns the number of bytes read; zero when at -- end of directory; or -1 for errors. */ -+ end of directory; or -1 for errors. -+ This is deprecated and getdents64 or readdir should be used instead. */ - # ifndef __USE_FILE_OFFSET64 - extern __ssize_t getdirentries (int __fd, char *__restrict __buf, - size_t __nbytes, - __off_t *__restrict __basep) -- __THROW __nonnull ((2, 4)); -+ __THROW __nonnull ((2, 4)) -+ __attribute_deprecated_msg__ ("Use getdents64 instead"); - # else - # ifdef __REDIRECT - extern __ssize_t __REDIRECT_NTH (getdirentries, - (int __fd, char *__restrict __buf, - size_t __nbytes, - __off64_t *__restrict __basep), -- getdirentries64) __nonnull ((2, 4)); -+ getdirentries64) -+ __nonnull ((2, 4)) -+ __attribute_deprecated_msg__ ("Use getdents64 instead"); - # else - # define getdirentries getdirentries64 - # endif - # endif - - # ifdef __USE_LARGEFILE64 -+/* This is deprecated and getdents64 or readdir64 should be used instead. */ - extern __ssize_t getdirentries64 (int __fd, char *__restrict __buf, - size_t __nbytes, - __off64_t *__restrict __basep) -- __THROW __nonnull ((2, 4)); -+ __THROW __nonnull ((2, 4)) -+ __attribute_deprecated_msg__ ("Use getdents64 instead"); - # endif - #endif /* Use misc. */ - -diff --git a/sysdeps/unix/sysv/linux/Makefile b/sysdeps/unix/sysv/linux/Makefile -index f298878e8f..41e5341450 100644 ---- a/sysdeps/unix/sysv/linux/Makefile -+++ b/sysdeps/unix/sysv/linux/Makefile -@@ -467,6 +467,10 @@ tests += \ - tst-getdents64 \ - tst-readdir64-compat \ - # tests -+ -+# Avoid the warning for the weak_alias for _DIRENT_MATCHES_DIRENT64 -+CFLAGS-getdirentries64.o = -Wno-deprecated-declarations -+CFLAGS-getdirentries64.os = -Wno-deprecated-declarations - endif # $(subdir) == dirent - - ifeq ($(subdir),nis) --- -2.38.2 - |