diff options
author | Sam James <sam@gentoo.org> | 2021-08-01 03:50:13 +0100 |
---|---|---|
committer | Ulrich Müller <ulm@gentoo.org> | 2021-12-22 16:36:22 +0100 |
commit | 7ce5e147a7ef3b776cb3910c0c21b999f7e2839b (patch) | |
tree | d3af04eaf48149a340f264e565bc72ef3b64dcc4 /ebuild-writing/common-mistakes/text.xml | |
parent | archs/amd64: econf passes --libdir by default (diff) | |
download | devmanual-7ce5e147a7ef3b776cb3910c0c21b999f7e2839b.tar.gz devmanual-7ce5e147a7ef3b776cb3910c0c21b999f7e2839b.tar.bz2 devmanual-7ce5e147a7ef3b776cb3910c0c21b999f7e2839b.zip |
ebuild-writing/common-mistakes: add calling external tools without die
Suggested-by: Joonas Niilola <juippis@gentoo.org>
Signed-off-by: Sam James <sam@gentoo.org>
[Internal cross reference fixed]
Signed-off-by: Ulrich Müller <ulm@gentoo.org>
Diffstat (limited to 'ebuild-writing/common-mistakes/text.xml')
-rw-r--r-- | ebuild-writing/common-mistakes/text.xml | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/ebuild-writing/common-mistakes/text.xml b/ebuild-writing/common-mistakes/text.xml index e0cdd12..4e26462 100644 --- a/ebuild-writing/common-mistakes/text.xml +++ b/ebuild-writing/common-mistakes/text.xml @@ -14,6 +14,19 @@ writing ebuilds. <title>Common Ebuild Writing Mistakes</title> <subsection> +<title>Unguarded external calls</title> +<body> + +<p> +Calls to external tools should be guarded with <c>|| die</c> (or use +<c>assert</c>) in almost all cases to allow failure to be detected. +See <uri link="::ebuild-writing/error-handling/"/>. +</p> + +</body> +</subsection> + +<subsection> <title>Invalid use of <c>static</c> use-flag</title> <body> <p> |