diff options
| author |   Alexey Bogdanenko <alexey@bogdanenko.com> | 2018-12-11 16:55:34 +0300 |
|---|---|---|
| committer | Alexey Bogdanenko <alexey@bogdanenko.com> | 2018-12-11 16:55:34 +0300 |
| commit | a680beb2fe912aadcddd3855d130e10a36e574d7 (patch) | |
| tree | e46c71972a73b2e61f4fdfb2703b58886846b264 /src | |
| parent | Merge pull request #11099 from abogdanenko/udev-test-fix-missing-dir (diff) | |
| download | systemd-a680beb2fe912aadcddd3855d130e10a36e574d7.tar.gz systemd-a680beb2fe912aadcddd3855d130e10a36e574d7.tar.bz2 systemd-a680beb2fe912aadcddd3855d130e10a36e574d7.zip | |
udev-test: add message to show why test-udev failed
Before:
Assertion 'mknod(devname, mode, devnum) == 0' failed at ../src/test/test-udev.c:116, function run(). Aborting.
Assertion 'unlink(devname) == 0' failed at ../src/test/test-udev.c:118, function run(). Aborting.
After:
mknod() failed for '/dev/sda': Operation not permitted
unlink('/dev/sda') failed: No such file or directory
Diffstat (limited to 'src')
| -rw-r--r-- | src/test/test-udev.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/test/test-udev.c b/src/test/test-udev.c index b5d3eb7bc..281dbb51f 100644 --- a/src/test/test-udev.c +++ b/src/test/test-udev.c @@ -113,9 +113,11 @@ static int run(int argc, char *argv[]) { (void) mkdir_parents_label(devname, 0755); (void) sd_device_get_devnum(dev, &devnum); - assert_se(mknod(devname, mode, devnum) == 0); + if (mknod(devname, mode, devnum) < 0) + return log_error_errno(errno, "mknod() failed for '%s': %m", devname); } else { - assert_se(unlink(devname) == 0); + if (unlink(devname) < 0) + return log_error_errno(errno, "unlink('%s') failed: %m", devname); (void) rmdir_parents(devname, "/"); } } |