aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authormkanat%bugzilla.org <>2006-08-26 05:10:38 +0000
committermkanat%bugzilla.org <>2006-08-26 05:10:38 +0000
commit3120e71d44a272228c0393bfe8be3d4653f2cd82 (patch)
treea867f3d272e48f1aec5dbbef3d530e5f4cd80ae7 /editusers.cgi
parentBug 347864: Generally improve fulltext search (diff)
downloadbugzilla-3120e71d44a272228c0393bfe8be3d4653f2cd82.tar.gz
bugzilla-3120e71d44a272228c0393bfe8be3d4653f2cd82.tar.bz2
bugzilla-3120e71d44a272228c0393bfe8be3d4653f2cd82.zip
Bug 349349: Use ->create from Bugzilla::Object instead of insert_new_user for Bugzilla::User
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=myk
Diffstat (limited to 'editusers.cgi')
-rwxr-xr-xeditusers.cgi38
1 files changed, 8 insertions, 30 deletions
diff --git a/editusers.cgi b/editusers.cgi
index 0ce3a95ce..4663b18ee 100755
--- a/editusers.cgi
+++ b/editusers.cgi
@@ -191,36 +191,14 @@ if ($action eq 'search') {
action => "add",
object => "users"});
- my $login = $cgi->param('login');
- my $password = $cgi->param('password');
- my $realname = trim($cgi->param('name') || '');
- my $disabledtext = trim($cgi->param('disabledtext') || '');
- my $disable_mail = $cgi->param('disable_mail') ? 1 : 0;
-
- # Lock tables during the check+creation session.
- $dbh->bz_lock_tables('profiles WRITE', 'profiles_activity WRITE',
- 'email_setting WRITE', 'user_group_map WRITE',
- 'groups READ', 'tokens READ', 'fielddefs READ');
-
- # Validity checks
- $login || ThrowUserError('user_login_required');
- validate_email_syntax($login)
- || ThrowUserError('illegal_email_address', {addr => $login});
- is_available_username($login)
- || ThrowUserError('account_exists', {email => $login});
- validate_password($password);
-
- # Login and password are validated now, and realname and disabledtext
- # are allowed to contain anything
- trick_taint($login);
- trick_taint($realname);
- trick_taint($password);
- trick_taint($disabledtext);
-
- insert_new_user($login, $realname, $password, $disabledtext, $disable_mail);
- my $new_user_id = $dbh->bz_last_key('profiles', 'userid');
- $dbh->bz_unlock_tables();
- userDataToVars($new_user_id);
+ my $new_user = Bugzilla::User->create({
+ login_name => $cgi->param('login'),
+ cryptpassword => $cgi->param('password'),
+ realname => $cgi->param('name'),
+ disabledtext => $cgi->param('disabledtext'),
+ disable_mail => $cgi->param('disable_mail')});
+
+ userDataToVars($new_user->id);
$vars->{'message'} = 'account_created';
$template->process('admin/users/edit.html.tmpl', $vars)