aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Burgess <aburgess@redhat.com>2022-06-09 15:21:37 +0100
committerAndrew Burgess <aburgess@redhat.com>2022-06-24 15:07:28 +0100
commitef7a6b977bf5e8499734a3b8df48ce2ca690cf57 (patch)
tree6055e8c25252a10abd352e3d0cbef0e762445c25 /gdb/testsuite/lib/compiler.c
parentInclude count of unexpected core files in gdb.sum summary (diff)
downloadbinutils-gdb-ef7a6b977bf5e8499734a3b8df48ce2ca690cf57.tar.gz
binutils-gdb-ef7a6b977bf5e8499734a3b8df48ce2ca690cf57.tar.bz2
binutils-gdb-ef7a6b977bf5e8499734a3b8df48ce2ca690cf57.zip
gdb/testsuite: remove global gcc_compiled from gdb.exp
After this commit the gcc_compiled global is no longer exported from lib/gdb.exp. In theory we could switch over all uses of gcc_compiled to instead call test_compiler_info directly, however, I have instead added a new proc to gdb.exp: 'is_c_compiler_gcc'. I've then updated the testsuite to call this proc instead of using the global. Having a new proc specifically for this task means that we have a single consistent pattern for detecting gcc. By wrapping this logic within a proc that calls test_compiler_info, rather than using the global, means that test scripts don't need to call get_compiler_info before they read the global, simply calling the new proc does everything in one go. As a result I've been able to remove the get_compiler_info calls from all the test scripts that I've touched in this commit. In some of the tests e.g. gdb.dwarf2/*.exp, the $gcc_compiled flag was being checked at the top of the script to decide if the whole script should be skipped or not. In these cases I've called the new proc directly and removed all uses of gcc_compiled. In other cases, e.g. most of the gdb.base scripts, there were many uses of gcc_compiled. In these cases I set a new global gcc_compiled near the top of the script, and leave the rest of the script unchanged. There should be no changes in what is tested after this commit.
Diffstat (limited to 'gdb/testsuite/lib/compiler.c')
-rw-r--r--gdb/testsuite/lib/compiler.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/gdb/testsuite/lib/compiler.c b/gdb/testsuite/lib/compiler.c
index 86140f8c0e7..25316abb407 100644
--- a/gdb/testsuite/lib/compiler.c
+++ b/gdb/testsuite/lib/compiler.c
@@ -27,9 +27,6 @@
TODO: make compiler_info a local variable for get_compiler_info and
test_compiler_info.
- TODO: all clients should use test_compiler_info and should not
- use gcc_compiled.
-
*/
set compiler_info "unknown"