diff options
| author |   Robin H. Johnson <robbat2@gentoo.org> | 2010-12-26 22:40:40 +0000 |
|---|---|---|
| committer | Robin H. Johnson <robbat2@gentoo.org> | 2010-12-26 22:40:40 +0000 |
| commit | 16da77e1213aab21c8664d0c2761d6398df9bc87 (patch) | |
| tree | fd4376de722c69c94c0eb6ccbfbddb3c950945bc /dev-vcs/git/files | |
| parent | old (diff) | |
| download | gentoo-2-16da77e1213aab21c8664d0c2761d6398df9bc87.tar.gz gentoo-2-16da77e1213aab21c8664d0c2761d6398df9bc87.tar.bz2 gentoo-2-16da77e1213aab21c8664d0c2761d6398df9bc87.zip | |
Bug #349083: Fix a false positive in the Git testsuite, triggered when the portage user had a shell of /bin/false.
(Portage version: 2.2.0_alpha6/cvs/Linux x86_64)
Diffstat (limited to 'dev-vcs/git/files')
| -rw-r--r-- | dev-vcs/git/files/git-1.7.3.4-avoid-shell-issues.patch | 26 |
1 files changed, 26 insertions, 0 deletions
diff --git a/dev-vcs/git/files/git-1.7.3.4-avoid-shell-issues.patch b/dev-vcs/git/files/git-1.7.3.4-avoid-shell-issues.patch new file mode 100644 index 000000000000..993f516a1767 --- /dev/null +++ b/dev-vcs/git/files/git-1.7.3.4-avoid-shell-issues.patch @@ -0,0 +1,26 @@ +Fix false positives in t3404 due to SHELL=/bin/false + +If the user's shell in NSS passwd is /bin/false (eg as found during Gentoo's +package building), the git-rebase exec tests will fail, because they call +$SHELL around the command, and in the existing testcase, $SHELL was not being +cleared sufficently. + +This lead to false positive failures of t3404 on systems where the package +build user was locked down as noted above. + +Signed-off-by: Robin H. Johnson <robbat2@gentoo.org> + +diff -Nuar git-1.7.3.4.orig/t/t3404-rebase-interactive.sh git-1.7.3.4/t/t3404-rebase-interactive.sh +--- git-1.7.3.4.orig/t/t3404-rebase-interactive.sh 2010-12-16 02:52:11.000000000 +0000 ++++ git-1.7.3.4/t/t3404-rebase-interactive.sh 2010-12-26 22:30:47.826421313 +0000 +@@ -67,8 +67,8 @@ + # "exec" commands are ran with the user shell by default, but this may + # be non-POSIX. For example, if SHELL=zsh then ">file" doesn't work + # to create a file. Unseting SHELL avoids such non-portable behavior +-# in tests. +-SHELL= ++# in tests. It must be exported for it to take effect where needed. ++export SHELL= + + test_expect_success 'rebase -i with the exec command' ' + git checkout master && |