From 28155dfc3ce5d7f5d9f19fe0239a27eaab29cccb Mon Sep 17 00:00:00 2001 From: Sam James Date: Fri, 13 Aug 2021 02:42:46 +0100 Subject: metadata/install-qa-check.d: add exemptions for some packages wrt inherit Both sys-apps/systemd and sys-libs/pam need to install some files to these directories without inheriting the eclass. For future work, we should have a standardised way on opting out of installed files QA checks, but other QA checks are already suffering from this issue. See: https://archives.gentoo.org/gentoo-dev/message/0a96793036a4fdd9ac311a46950d7e7b Signed-off-by: Sam James --- metadata/install-qa-check.d/60tmpfiles-paths | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'metadata/install-qa-check.d') diff --git a/metadata/install-qa-check.d/60tmpfiles-paths b/metadata/install-qa-check.d/60tmpfiles-paths index 5ef56885ebe7..81286de584a2 100644 --- a/metadata/install-qa-check.d/60tmpfiles-paths +++ b/metadata/install-qa-check.d/60tmpfiles-paths @@ -30,6 +30,14 @@ tmpfiles_check() { return fi + # It's okay for some packages to do this because of circular dependencies and such + # See: https://archives.gentoo.org/gentoo-dev/message/0a96793036a4fdd9ac311a46950d7e7b + # TODO: Standardize some way of allowing ebuilds to opt-out of checks like this + local package=${CATEGORY}/${PN} + if [[ ${package} == "sys-apps/systemd" || ${package} == "sys-libs/pam" ]] ; then + return + fi + if [[ -d "${ED}"/usr/lib/tmpfiles.d/ ]] ; then eqawarn "QA Notice: package is installing tmpfiles without inheriting tmpfiles.eclass!" eqawarn "Packages must inherit tmpfiles.eclass then call tmpfiles_process in pkg_postinst." -- cgit v1.2.3-65-gdbad