diff options
| author |   Hans Wennborg <hans@hanshq.net> | 2019-02-27 14:52:42 +0000 |
|---|---|---|
| committer | Hans Wennborg <hans@hanshq.net> | 2019-02-27 14:52:42 +0000 |
| commit | a4fc3887e7837406e3fd8a46400d958abbcc240e (patch) | |
| tree | e9a0732b5e9d21f4341b8adbfc4c34ee2e1e56d5 | |
| parent | ReleaseNotes: tidy up (clangd notes are still expected) (diff) | |
| download | llvm-project-a4fc3887e7837406e3fd8a46400d958abbcc240e.tar.gz llvm-project-a4fc3887e7837406e3fd8a46400d958abbcc240e.tar.bz2 llvm-project-a4fc3887e7837406e3fd8a46400d958abbcc240e.zip | |
Merging r353422:
------------------------------------------------------------------------
r353422 | kadircet | 2019-02-07 17:04:30 +0100 (Thu, 07 Feb 2019) | 18 lines
[clangd] Reduce number of threads used by BackgroundIndex to number of physical cores.
Summary:
clangd is using as many threads as logical cores for BackgroundIndex
by default. We observed that it increases latency of foreground tasks.
This patch aims to change that default to number of physical cores to get rid of
that extra latency.
Reviewers: ilya-biryukov
Reviewed By: ilya-biryukov
Subscribers: ioeric, MaskRay, jkorous, arphaman, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D57819
------------------------------------------------------------------------
llvm-svn: 354980
| -rw-r--r-- | clang-tools-extra/clangd/index/Background.h | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/clang-tools-extra/clangd/index/Background.h b/clang-tools-extra/clangd/index/Background.h index 81675be55b5a..ffa83e60d826 100644 --- a/clang-tools-extra/clangd/index/Background.h +++ b/clang-tools-extra/clangd/index/Background.h @@ -68,11 +68,12 @@ public: /// If BuildIndexPeriodMs is greater than 0, the symbol index will only be /// rebuilt periodically (one per \p BuildIndexPeriodMs); otherwise, index is /// rebuilt for each indexed file. - BackgroundIndex(Context BackgroundContext, const FileSystemProvider &, - const GlobalCompilationDatabase &CDB, - BackgroundIndexStorage::Factory IndexStorageFactory, - size_t BuildIndexPeriodMs = 0, - size_t ThreadPoolSize = llvm::hardware_concurrency()); + BackgroundIndex( + Context BackgroundContext, const FileSystemProvider &, + const GlobalCompilationDatabase &CDB, + BackgroundIndexStorage::Factory IndexStorageFactory, + size_t BuildIndexPeriodMs = 0, + size_t ThreadPoolSize = llvm::heavyweight_hardware_concurrency()); ~BackgroundIndex(); // Blocks while the current task finishes. // Enqueue translation units for indexing. |