From cc8dcf96e71dd643f929e32150904cd6ad69efa8 Mon Sep 17 00:00:00 2001 From: Florian Weimer Date: Mon, 27 Apr 2015 15:41:03 +0200 Subject: test-skeleton: Support temporary files without memory leaks [BZ#18333] add_temp_file now makes a copy which is freed by delete_temp_files. Callers to create_temp_file can now free the returned file name to avoid the memory leak. These changes do not affect the leak behavior of existing code. Also address a NULL pointer derefence in tzset after a memoru allocation failure, found during testing. --- time/tzset.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'time') diff --git a/time/tzset.c b/time/tzset.c index d115bae0be..160f5ad460 100644 --- a/time/tzset.c +++ b/time/tzset.c @@ -201,7 +201,12 @@ parse_tzname (const char **tzp, int whichrule) if (*p++ != '>' || len < 3) return false; } - tz_rules[whichrule].name = __tzstring_len (start, len); + + const char *name = __tzstring_len (start, len); + if (name == NULL) + return false; + tz_rules[whichrule].name = name; + *tzp = p; return true; } -- cgit v1.2.3-65-gdbad