From a39a4ef297b2435cbd4a4ef50d459b68c8bb6106 Mon Sep 17 00:00:00 2001 From: "lpsolit%gmail.com" <> Date: Sat, 21 Oct 2006 06:21:08 +0000 Subject: Bug 356328: $rankdir should be validated in showdependencygraph.cgi - Patch by Frédéric Buclin r=bkor a=myk MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- showdependencygraph.cgi | 9 +++++++++ 1 file changed, 9 insertions(+) (limited to 'showdependencygraph.cgi') diff --git a/showdependencygraph.cgi b/showdependencygraph.cgi index e483fd0f8..2cea9b2f2 100755 --- a/showdependencygraph.cgi +++ b/showdependencygraph.cgi @@ -96,7 +96,16 @@ sub AddLink { } } +# The list of valid directions. Some are not proposed in the dropdrown +# menu despite they are valid ones. +my @valid_rankdirs = ('LR', 'RL', 'TB', 'BT'); + my $rankdir = $cgi->param('rankdir') || "LR"; +# Make sure the submitted 'rankdir' value is valid. +if (lsearch(\@valid_rankdirs, $rankdir) < 0) { + $rankdir = 'LR'; +} + my $webdotdir = bz_locations()->{'webdotdir'}; if (!defined $cgi->param('id') && !defined $cgi->param('doall')) { -- cgit v1.2.3-65-gdbad