diff options
| author |   mkanat%kerio.com <> | 2005-07-08 10:39:19 +0000 |
|---|---|---|
| committer | mkanat%kerio.com <> | 2005-07-08 10:39:19 +0000 |
| commit | cf64b9f38956ebaa7742fec630c0ca41b1c15a3d (patch) | |
| tree | d8c9eda0365a372a8131d824e0b088fb0ee81f7b | |
| parent | Bug 292768: [PostgreSQL] COALESCE requires both arguments to be of similar types (diff) | |
| download | bugzilla-cf64b9f38956ebaa7742fec630c0ca41b1c15a3d.tar.gz bugzilla-cf64b9f38956ebaa7742fec630c0ca41b1c15a3d.tar.bz2 bugzilla-cf64b9f38956ebaa7742fec630c0ca41b1c15a3d.zip | |
Bug 300006: "cookies need value" error code when a query returns an empty result.
Patch By Marc Schumann <wurblzap@gmail.com> r=glob, a=justdave
| -rwxr-xr-x | buglist.cgi | 5 | ||||
| -rwxr-xr-x | colchange.cgi | 11 |
2 files changed, 12 insertions, 4 deletions
diff --git a/buglist.cgi b/buglist.cgi index edacd836e..4768843de 100755 --- a/buglist.cgi +++ b/buglist.cgi @@ -1013,7 +1013,10 @@ if ($format->{'extension'} eq "html") { } my $bugids = join(":", @bugidlist); # See also Bug 111999 - if (length($bugids) < 4000) { + if (length($bugids) == 0) { + $cgi->remove_cookie('BUGLIST'); + } + elsif (length($bugids) < 4000) { $cgi->send_cookie(-name => 'BUGLIST', -value => $bugids, -expires => 'Fri, 01-Jan-2038 00:00:00 GMT'); diff --git a/colchange.cgi b/colchange.cgi index 235da6a01..30103406f 100755 --- a/colchange.cgi +++ b/colchange.cgi @@ -103,9 +103,14 @@ if (defined $cgi->param('rememberedquery')) { my $list = join(" ", @collist); my $urlbase = Param("urlbase"); - $cgi->send_cookie(-name => 'COLUMNLIST', - -value => $list, - -expires => 'Fri, 01-Jan-2038 00:00:00 GMT'); + if ($list) { + $cgi->send_cookie(-name => 'COLUMNLIST', + -value => $list, + -expires => 'Fri, 01-Jan-2038 00:00:00 GMT'); + } + else { + $cgi->remove_cookie('COLUMNLIST'); + } if ($splitheader) { $cgi->send_cookie(-name => 'SPLITHEADER', -value => $splitheader, |