summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Tromey <tromey@adacore.com>2021-11-03 07:33:24 -0600
committerTom Tromey <tromey@adacore.com>2021-11-03 07:33:24 -0600
commitdac784d0e4cb7255646ea298b39a5443055a4bb2 (patch)
tree69fc3645a7f64604923a0b66a80ed372f10f3460 /binutils/dwarf.c
parent[AArch64] Make gdbserver register set selection dynamic (diff)
downloadbinutils-gdb-dac784d0e4cb7255646ea298b39a5443055a4bb2.tar.gz
binutils-gdb-dac784d0e4cb7255646ea298b39a5443055a4bb2.tar.bz2
binutils-gdb-dac784d0e4cb7255646ea298b39a5443055a4bb2.zip
Use section name in warnings in display_debug_loc
While looking at an apparently malformed executable with "readelf --debug-dump=loc", I got this warning: readelf: ./main: Warning: There is a hole [0x89 - 0x95] in .debug_loc section. However, the executable only has a .debug_loclists section. This patch fixes the warning messages in display_debug_loc to use the name of the section that is being processed. binutils/ChangeLog 2021-11-03 Tom Tromey <tromey@adacore.com> * dwarf.c (display_debug_loc): Use section name in warnings.
Diffstat (limited to 'binutils/dwarf.c')
-rw-r--r--binutils/dwarf.c20
1 files changed, 12 insertions, 8 deletions
diff --git a/binutils/dwarf.c b/binutils/dwarf.c
index a118c5b794e..9fed11383a8 100644
--- a/binutils/dwarf.c
+++ b/binutils/dwarf.c
@@ -7022,28 +7022,32 @@ display_debug_loc (struct dwarf_section *section, void *file)
else
{
if (start < next)
- warn (_("There is a hole [0x%lx - 0x%lx] in .debug_loc section.\n"),
+ warn (_("There is a hole [0x%lx - 0x%lx] in %s section.\n"),
(unsigned long) (start - section_begin),
- (unsigned long) offset);
+ (unsigned long) offset,
+ section->name);
else if (start > next)
- warn (_("There is an overlap [0x%lx - 0x%lx] in .debug_loc section.\n"),
+ warn (_("There is an overlap [0x%lx - 0x%lx] in %s section.\n"),
(unsigned long) (start - section_begin),
- (unsigned long) offset);
+ (unsigned long) offset,
+ section->name);
}
start = next;
vstart = vnext;
if (offset >= bytes)
{
- warn (_("Offset 0x%lx is bigger than .debug_loc section size.\n"),
- (unsigned long) offset);
+ warn (_("Offset 0x%lx is bigger than %s section size.\n"),
+ (unsigned long) offset,
+ section->name);
continue;
}
if (vnext && voffset >= bytes)
{
- warn (_("View Offset 0x%lx is bigger than .debug_loc section size.\n"),
- (unsigned long) voffset);
+ warn (_("View Offset 0x%lx is bigger than %s section size.\n"),
+ (unsigned long) voffset,
+ section->name);
continue;
}